Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpeziFoundation #139

Merged
merged 13 commits into from
Nov 10, 2024
Merged

SpeziFoundation #139

merged 13 commits into from
Nov 10, 2024

Conversation

pauljohanneskraft
Copy link
Contributor

SpeziFoundation

♻️ Current situation & Problem

Link any open issues or pull requests (PRs) related to this PR. Please ensure that all non-trivial PRs are first tracked and discussed in an existing GitHub issue or discussion.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@pauljohanneskraft pauljohanneskraft self-assigned this Nov 8, 2024
@pauljohanneskraft pauljohanneskraft added the enhancement New feature or request label Nov 8, 2024
@pauljohanneskraft pauljohanneskraft marked this pull request as ready for review November 8, 2024 22:02
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.67%. Comparing base (5009495) to head (a7d384d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rd/spezi/core/utils/foundation/SharedRepository.kt 92.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #139      +/-   ##
============================================
+ Coverage     39.48%   39.67%   +0.19%     
- Complexity      792      799       +7     
============================================
  Files           265      267       +2     
  Lines         10532    10567      +35     
  Branches       1479     1485       +6     
============================================
+ Hits           4158     4191      +33     
  Misses         6014     6014              
- Partials        360      362       +2     
Flag Coverage Δ
uitests 33.50% <ø> (ø)
unittests 33.56% <94.29%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...i/core/utils/foundation/builtin/ValueRepository.kt 100.00% <100.00%> (ø)
...rd/spezi/core/utils/foundation/SharedRepository.kt 92.00% <92.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5009495...a7d384d. Read the comment docs.

@pauljohanneskraft pauljohanneskraft enabled auto-merge (squash) November 10, 2024 20:50
@pauljohanneskraft pauljohanneskraft merged commit 11ae70a into main Nov 10, 2024
11 checks passed
@pauljohanneskraft pauljohanneskraft deleted the feature/spezi-foundation branch November 10, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants